chore(gestures): fix treeshaking for core #2447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Treeshaking may break in Webpack and other bundlers for the `core` exports because our compiled JavaScript files are trying to export everything (`export *`) from the gesture-annotations file The problem with the `gesture-annotations` is, that the transpiled JavaScript file is barely empty (due to TypeScript-only interfaces) * When exporting the different interfaces manually, TypeScript is smart-enough to export nothing in the resulting JavaScript file. Closes angular#2401
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Treeshaking may break in Webpack and other bundlers for the
coreexports because our compiled JavaScript files are trying to export everything (export *) from the gesture-annotations fileThe problem with the
gesture-annotationsis, that the transpiled JavaScript file is barely empty (due to TypeScript-only interfaces)See response from the Webpack team - webpack/webpack#3584 (comment)
@jelbourn Also thought about moving the annotations to the
gesture-configfile, but it's definitely nicer to have them separated.Closes #2401